Merge pull request #726 from forsbergplustwo/pagination_fix

Make cursor based pagination return relative uri's when fetching next and previous pages
Shopify · May 8, 2020 · af01894 · af01894
2 parents 0f9c1b5 + bf3fc91
commit af01894
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## Version 9.1.1
+
+* Make cursor based pagination return relative uri's when fetching next and previous pages. [#726](https://github.com/Shopify/shopify_api/pull/726)
+
 ## Version 9.1.0
 
 * Implements equality operator on `Session` [#714](https://github.com/Shopify/shopify_api/pull/714)

diff --git a/lib/shopify_api/pagination_link_headers.rb b/lib/shopify_api/pagination_link_headers.rb
@@ -25,7 +25,7 @@ def parse_link_header(link_header)
         url = parts[0][/<(.*)>/, 1]
         rel = parts[1][/rel="(.*)"/, 1]&.to_sym
 
-        url = URI.parse(url)
+        url = URI.parse(url).request_uri
         LinkHeader.new(url, rel)
       end
     end

diff --git a/lib/shopify_api/version.rb b/lib/shopify_api/version.rb
@@ -1,3 +1,3 @@
 module ShopifyAPI
-  VERSION = "9.1.0"
+  VERSION = "9.1.1"
 end