Use Bundler CLI directly and send errors to telemetry #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
vinistock
force-pushed
the
vs-invoke-bundler-cli
branch
2 times, most recently
from
d34d293 to
6976d2b
Compare
vinistock
force-pushed
the
vs-invoke-bundler-cli
branch
23 times, most recently
from
8311af8 to
35ad8ab
Compare
vinistock
force-pushed
the
vs-invoke-bundler-cli
branch
12 times, most recently
from
added77 to
be7f01c
Compare
This was referenced Oct 29, 2024
vinistock
force-pushed
the
vs-invoke-bundler-cli
branch
from
be7f01c to
bbc0a44
Compare
andyw8
reviewed
Oct 30, 2024
vinistock
force-pushed
the
vs-invoke-bundler-cli
branch
from
bbc0a44 to
0c4392b
Compare
andyw8
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR starts invoking the Bundler CLI objects for install and update directly on the new launcher strategy instead of shelling out.
This will provide us with two benefits: one is performance since we don't have to start a whole new process to start running Bundler commands. The second is that we can now rescue the errors and send them to telemetry, so that we can understand what are the common failures to bundle install and start making it more robust.
Implementation
The idea is to invoke
Bundler::CLI::{Install,Update}as needed, rescue errors and report them to the editor as telemetry.I'm also enabling YJIT in the child process that sets up the composed bundle, since it speeds up both install and update.
Automated Tests
Added tests.