Add some necessary guards for operating with a partial bundle #2797
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
st0012
approved these changes
Oct 29, 2024
|
It's already possible to start without a Gemfile, but this makes it possible to start if you are only missing the lockfile or if Bundler.setup fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For launcher mode #2774, we will need to add some necessary guards for operating with a partial bundle. For example, if
Bundler.setupfails, then the load path is not going to be configured and we cannot try to load RuboCop.Similarly, since we will start allowing running the server even the top level bundle isn't locked yet, we need to protect requests like workspace dependencies.
Implementation
Just added a few necessary guards to prevent breaking under failure scenarios.