Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also run checks when PRs are opened #195

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Also run checks when PRs are opened #195

merged 1 commit into from
Mar 4, 2022

Conversation

Mangara
Copy link
Contributor

@Mangara Mangara commented Mar 4, 2022

We received an external PR, but CI did not run on it. I suspect it's because the workflow only triggers on push, and this PR was from a branch in a fork. This PR adds the pull_request trigger, so hopefully CI will run on these type of PRs in the future.

@Mangara Mangara self-assigned this Mar 4, 2022
Copy link
Contributor

@adrianna-chang-shopify adrianna-chang-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we ship the PR to fix CI ,🚢 !

@Mangara Mangara force-pushed the mangara-run-ci-on-pr branch from b17c1fb to 2fc4cfa Compare March 4, 2022 21:22
@Mangara Mangara merged commit b9854ba into main Mar 4, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems March 4, 2022 21:33 Inactive
@sambostock sambostock deleted the mangara-run-ci-on-pr branch February 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants