Add Ruby 3.1 and Rails 6.1 and 7 to the CI matrix #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mangara
reviewed
Mar 4, 2022
|
|
||
| eval_gemfile "../Gemfile" | ||
|
|
||
| if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new("3.1") |
There was a problem hiding this comment.
Can you explain why this is necessary?
There was a problem hiding this comment.
The mail gem has an issue discussing the need here - mikel/mail#1439 . And the Rails team discusses it here - rails/rails#44600 .
These gems are not included by default in Ruby 3.1, so they need to be explicitly included. Attempting to explicitly include them in older Rubies causes issues, so the invoking Gemfile is supposed to explicitly include them.
|
I want to see a CI run for this PR before merging. I think we had an issue in our workflow setup that prevented it from triggering a CI run. That should be corrected after merging #195, so I'm going to close and re-open this PR to try and trigger a CI run. |
Mangara
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit gemfiles for Rails 6.1 and Rails 7. It updates the Ruby 3.1 configuration to run against these two new entries as well as against Rails edge.