Support optional segments in check routes CLI command
#774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
lordofthecactus
added a commit
that referenced
this pull request
Apr 20, 2023
This reverts commit 2039a4a.
lordofthecactus
added a commit
that referenced
this pull request
Apr 20, 2023
blittle
pushed a commit
that referenced
this pull request
May 12, 2023
frehner
added a commit
that referenced
this pull request
May 17, 2023
* Fix 2023 01 (#807) * Revert "Support optional segments in `check routes` CLI command (#774)" This reverts commit 2039a4a. * update package.lock * Fix demo store search action url (#802) * Fixing #825 * Add loading dependency to redirect effect * Revert "Fix 2023 01 (#807)" This reverts commit 53e6dbf. * Revert "Fix demo store search action url (#802)" This reverts commit a783b42. * add a changeset --------- Co-authored-by: Daniel Rios <[email protected]> Co-authored-by: Ós <[email protected]> Co-authored-by: Anthony Frehner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #749
The
h2 check routescommand was matching($lang)/cartbut not(lang)/cart(i.e. optional segment instead of optional parameter). I've added support for that and also for optional segments and parameters in any position of the URL. It will now also match/cart/(extra)since the extra bit is optional.