check routes incompatible with optional path segments and pathless layout routes

[duncan-fairley]

What is the location of your example repository?

https://github.com/DuncanFa/hydrogen-paths

Which package or tool is having this issue?

CLI

What version of that package or tool are you using?

3.29.0

What version of Remix are you using?

1.14.0

Steps to Reproduce

1. Clone https://github.com/DuncanFa/hydrogen-paths
2. Inside project run yarn followed by yarn build
3. Run yarn shopify hydrogen check routes

Expected Behavior

warning 

Standard Shopify routes missing                                                                                                           
                                                                                                                                        
Your Hydrogen project is missing 16 standard Shopify routes.                                                                              
Including these routes improves compatibility with Shopify’s platform:                                                                    
                                                                                                                                                                                                                                              
• /sitemap.xml                                                                                                                            
• /robots.txt                                                                                                                             
• /pages/:pageHandle                                                                                                                      
• /policies/:policyHandle                                                                                                                 
• /search                                                                                                                                 
• /discount/:discountCode                                                                                                                 
• /account                                                                                                                                
• /account/login                                                                                                                          
• /account/register                                                                                                                       
• /account/orders/:orderId                                                                                                                
• /account/reset/:id/:token                                                                                                               
• /account/activate/:id/:token      

Actual Behavior

warning 

Standard Shopify routes missing                                                                                                           
                                                                                                                                        
Your Hydrogen project is missing 16 standard Shopify routes.                                                                              
Including these routes improves compatibility with Shopify’s platform:                                                                    
                                                                                                                                        
• /products                                                                                                                               
• /products/:productHandle                                                                                                                
• /collections                                                                                                                            
• /collections/:collectionHandle                                                                                                          
• /sitemap.xml                                                                                                                            
• /robots.txt                                                                                                                             
• /pages/:pageHandle                                                                                                                      
• /policies/:policyHandle                                                                                                                 
• /search                                                                                                                                 
• /discount/:discountCode                                                                                                                 
• /account                                                                                                                                
• /account/login                                                                                                                          
• /account/register                                                                                                                       
• /account/orders/:orderId                                                                                                                
• /account/reset/:id/:token                                                                                                               
• /account/activate/:id/:token      

[frandiox]

Thanks for the report and the reproduction!

I think pathless layout routes actually work in general. It doesn't in your repro because it's also nested in an optional segment.
I'm adding support for optional segments in #774 👍

[duncan-fairley]

Thanks @frandiox! Nice work