Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise subrequest limit in development #1348

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Raise subrequest limit in development #1348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e7c759
Raise the subrequest limit to 100 in development
frandiox Sep 19, 2023
fb79c98
Changesets
frandiox Sep 19, 2023
7c59e7b
Merge branch 'main' into fd-subrequest-limit
frandiox Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/seven-lies-bow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/cli-hydrogen': patch
---

Raise the subrequest limit to 100 for development.
5 changes: 5 additions & 0 deletions packages/cli/src/lib/mini-oxygen/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ export async function startMiniOxygen(
const {startWorkerdServer} = await import('./workerd.js');
return startWorkerdServer(options);
} else {
// @ts-expect-error Valid env var for Miniflare v2:
// https://github.com/cloudflare/miniflare/blob/f919a2eaccf30d63f435154969e4233aa3b9531c/packages/shared/src/context.ts#L18
// Note: this must be set before importing Miniflare
process.env.MINIFLARE_SUBREQUEST_LIMIT = 100;

const {startNodeServer} = await import('./node.js');
return startNodeServer(options);
}
Expand Down