Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise subrequest limit in development #1348

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Raise subrequest limit in development #1348

merged 3 commits into from
Sep 21, 2023

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Sep 19, 2023

Needs #1184 merged first.

This only works with the Node.js sandbox though, since afaik Workerd doesn't add any limit yet.

@frandiox frandiox requested a review from a team September 20, 2023 01:19
Base automatically changed from fd-mini-oxygen-workerd to main September 20, 2023 07:30
Copy link
Contributor

@wizardlyhel wizardlyhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, workerd doesn't have any sub request limit but the production workers does have a limit

@frandiox
Copy link
Contributor Author

Yeah, they mention in a discussion why, but I think it's more related to CPU/Memory limits than subrequest limit. I guess the latter was just a collateral effect of not implementing limits for the others 😅

@frandiox frandiox merged commit 3325821 into main Sep 21, 2023
@frandiox frandiox deleted the fd-subrequest-limit branch September 21, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants