Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hydrogen-ui dev and build issues #1169

Merged
merged 1 commit into from
May 2, 2022
Merged

Fix hydrogen-ui dev and build issues #1169

merged 1 commit into from
May 2, 2022

Conversation

frehner
Copy link
Contributor

@frehner frehner commented May 2, 2022

TS wasn't putting the output files in the dist dir

@frehner
Fix hydrogen-ui dev and build issues
a32e6f7 
TS wasn't putting the output files in the dist dir
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run "yarn changeset add" to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@frehner frehner requested a review from a team May 2, 2022 20:01
jplhomer
jplhomer approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@jplhomer jplhomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classic

@frehner frehner merged commit 2ecf98b into v1.x-2022-07 May 2, 2022
@frehner frehner deleted the hui-build-issues branch May 2, 2022 20:16
blittle added a commit that referenced this pull request May 4, 2022
@blittle
Merge branch 'v1.x-2022-07' into bl-countries-session
afc036a 
* v1.x-2022-07: (95 commits)
  [ci] release v1.x-2022-07 (#1170)
  Try ignoring hello-world to see if it will get bumped
  Don't consider examples part of the workspace (#1202)
  Fix headers on oxygen (#1201)
  Add bot user agents for Seoradar and Adresults, resolves #1199 (#1200)
  Fix changeset
  updates to docker deploy documentation to resolve run issues (#1196)
  Upgrade body-parser (#1162)
  Fix path for deployments
  Adds ability to add more than one cookie per response (#1161)
  Move Demo Store to templates folder (#1132)
  Avoid additional div element (#1191)
  Whoops this should only be patch
  Adds preconnect <link> for CDN (#1160)
  Bump ejs from 3.1.6 to 3.1.7 (#1147)
  Fix scroll restoration when server props are changed (#1152)
  Typo
  Fixes #1165 by making a missing alt tag a console warning (#1167)
  Remove concurrency directive for Oxygen deployments
  Fix hydrogen-ui dev and build issues (#1169)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplhomer jplhomer jplhomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frehner @jplhomer