Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] <MediaFile> breaks if no alt text is assigned to a 3D Model #1165

Closed
elisenyang opened this issue May 2, 2022 · 0 comments · Fixed by #1167
Closed

[BUG] <MediaFile> breaks if no alt text is assigned to a 3D Model #1165

elisenyang opened this issue May 2, 2022 · 0 comments · Fixed by #1167
Assignees
@benjaminsehl
Labels
bug Something isn't working hydrogen-ui Components, hooks, and utilities

Comments

@elisenyang
Copy link
Contributor

Expected behaviour
The component should render the model and provide a warning that alt text is missing, rather than an error.
@elisenyang elisenyang added bug Something isn't working hydrogen-ui Components, hooks, and utilities labels May 2, 2022
benjaminsehl added a commit that referenced this issue May 2, 2022
@benjaminsehl
Fixes #1165 by making a missing alt tag a console warning
a4d8384
@benjaminsehl benjaminsehl mentioned this issue May 2, 2022
Merged
4 tasks
benjaminsehl added a commit that referenced this issue May 2, 2022
@benjaminsehl
Fixes #1165 by making a missing alt tag a console warning (#1167)
0a5ac1c 
* Fixes #1165 by making a missing alt tag a console warning

* Adds changeset

* Remove alt from PropsWeControl type
blittle added a commit that referenced this issue May 4, 2022
@blittle
Merge branch 'v1.x-2022-07' into bl-countries-session
afc036a 
* v1.x-2022-07: (95 commits)
  [ci] release v1.x-2022-07 (#1170)
  Try ignoring hello-world to see if it will get bumped
  Don't consider examples part of the workspace (#1202)
  Fix headers on oxygen (#1201)
  Add bot user agents for Seoradar and Adresults, resolves #1199 (#1200)
  Fix changeset
  updates to docker deploy documentation to resolve run issues (#1196)
  Upgrade body-parser (#1162)
  Fix path for deployments
  Adds ability to add more than one cookie per response (#1161)
  Move Demo Store to templates folder (#1132)
  Avoid additional div element (#1191)
  Whoops this should only be patch
  Adds preconnect <link> for CDN (#1160)
  Bump ejs from 3.1.6 to 3.1.7 (#1147)
  Fix scroll restoration when server props are changed (#1152)
  Typo
  Fixes #1165 by making a missing alt tag a console warning (#1167)
  Remove concurrency directive for Oxygen deployments
  Fix hydrogen-ui dev and build issues (#1169)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminsehl benjaminsehl

Labels
bug Something isn't working hydrogen-ui Components, hooks, and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1165 by making a missing alt tag a console warning Shopify/hydrogen-v1
2 participants
@benjaminsehl @elisenyang