Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Merge the long awaited Examples sandbox #118

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Conversation

beefchimi
Copy link
Contributor

@beefchimi beefchimi commented Jan 15, 2018

While there are still a few items that remain to be resolved, this PR is ready to merge into master. Merging this will resolve:

I will spend the next few days making some tiny adjustments to it before hosting the dist files.

Tasks for Draggable

  • OneAndOnly: [Beta.4] Height issue using mirror: {constrainDimensions: true}
  • MultipleContainers: [Beta.4] Uncaught DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
  • MultipleContainers: Why does evt.cancel() not work as expected?
  • Floated: I'm having a hard time with the placed class and options... can we please chat about this?
  • Collidable: Need to have the draggable-container--over class applied on initial pickup (if it is of course over the container... which, it should be?)
  • Collidable: There should be a draggable-collidable--colliding class
  • SwapAnimation: Cannot finish this until we support swapping on both the x and y axis.
  • Draggable: Can you please add a watch task for work on the library? I want people to be able to develop both the library and the examples simultaneously.

Questions

  • All: When dragging <a> tags on iOS, I often get a delay, and the contextual menu. Is there a fix for this?
  • Lib: Should we be transpiling the library to ES5? Or should we instead ask the consumer to do it?
  • Droppable: Do we expect to add the ability for "capacity" in Droppable? Or do we instead prefer to just ask consumers to use logic for a normal container to not accept more than x children?
  • Collidable: I have an idea for Collidable... let's chat in person.
  • Examples folder: Do we want to disable CI from looking at /examples?

Examples site

  • Go over entire site for accessibility audit once accessibility is finished.
  • Is the striped gradient wacky in other browsers?
  • Finish MultipleContainers example.
  • Eventually make the "slider puzzle" Restrict Axis example.
  • Eventually make the Droppable capacity example.
  • Would be nice to both stretch and squish the plates... but that could be a bit too tricky
  • Rename all assets that might be cached by the landing page service worker
  • Figure out a way to prevent the 2nd placed animation on release of Snappable... maybe a release modifier class?

@beefchimi beefchimi self-assigned this Jan 15, 2018
@beefchimi beefchimi added feature-request requesting new functionality to be added examples specific to the examples directory labels Jan 15, 2018
@beefchimi beefchimi force-pushed the examples branch 2 times, most recently from 4a38931 to 34711d8 Compare January 16, 2018 03:04
@beefchimi beefchimi requested a review from tsov January 16, 2018 03:06
Copy link
Member

@tsov tsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 ❤️

@fredbenenson
Copy link

Awesome!

@beefchimi beefchimi changed the title Examples site [Examples] Merge the long awaited Examples sandbox Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples specific to the examples directory feature-request requesting new functionality to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants