Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local setup guide #50

Closed
svinkle opened this issue Oct 4, 2017 · 4 comments
Closed

Local setup guide #50

svinkle opened this issue Oct 4, 2017 · 4 comments
Assignees
Labels
examples specific to the examples directory

Comments

@svinkle
Copy link
Member

svinkle commented Oct 4, 2017

Hi! I'm looking to send in some issues and PRs regarding accessibility, but before I do that I need to know how to set things up locally!

I have the project forked and cloned, and I'm running a local Python http server on the gh-pages branch, as that branch includes the index.html file.

My question is, when I make a change do I need to run npm run build after each save in order to see my changes? If so, perhaps we could implement something like browsersync to automatically run the build on save?

Thanks for the assist!

@tsov
Copy link
Member

tsov commented Oct 9, 2017

@svinkle Thank you for your question!

The local setup is pretty minimal at the moment, we haven't had a chance to build a local playground for testing code changes. This is definitely on our list and will be addressed! If you want to watch for code changes you can use webpack --watch or ./node_modules/.bin/webpack --watch.

In terms of accessibility, we are currently working on an out of the box solution that can be further enhanced by the user. We've been addressing a number of issues in the v1.0.0-beta.2 branch for the next release, and accessibility will be a part of that release. I'd love to get some feedback on the approach though and would be more than happy to accept any alternative solutions in issue/PR form 🙂 I was planning on posting updates on accessibility in #48, but can keep you updated in here too 👍

@svinkle
Copy link
Member Author

svinkle commented Oct 10, 2017

@tsov I see that webpack builds the lib/draggable.js file, but the included index.html calls the assets/js/app.js file. I don't see any configuration that builds the app.js file?

For accessibility issues, I'll keep watch on #48 but may create some specific issues of my own, if I get this up and running locally. 🙂

@beefchimi
Copy link
Contributor

@svinkle I keep all of the source files for the site in a separate, private repo. I'm hoping to throw some barebones examples together to be hosted in this repo. I think it will be a lot easier for folks to experiment with the library without all the additional code for the site (although admittedly its currently impossible when I don't provide any examples...)

By the time we do a stable release, I hope to have at least of a few examples available.

@beefchimi beefchimi self-assigned this Jan 16, 2018
@beefchimi beefchimi added the examples specific to the examples directory label Jan 16, 2018
@beefchimi
Copy link
Contributor

Closed by #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples specific to the examples directory
Projects
None yet
Development

No branches or pull requests

3 participants