Use expiration parameter in getVAPIDAuthorizationHeader #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was being ignored, and would always use a value based on 12 hours after time.Now(). With this change, expiration is now used as provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state of the repository,
expirationwas being ignored ingetVAPIDAuthorizationHeader, and would always use a value based on 12 hours after time.Now(). This seems to be the result of a bad merge conflict resolution, as it was correct in #45 but the merge commit for #46 backed out the relevant change.With this PR, expiration is now used as provided, reintroducing the behavior added in #45. A test is also added to catch any potential future breakage here.
Fixes #73.