You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
webpush.Options has a dedicated VapidExpiration field documented as:
VapidExpirationtime.Time// optional expiration for VAPID JWT token (defaults to now + 12 hours)
It was introduced in #45. SendNotificationWithContext passes it into getVAPIDAuthorizationHeader, and in #45, getVAPIDAuthorizationHeader used it when forming the exp claim. However, what looks to have been a faulty merge conflict resolution in #46 seems to have reverted the change in getVAPIDAuthorizationHeader, leaving expiration unused:
webpush.Options
has a dedicatedVapidExpiration
field documented as:It was introduced in #45.
SendNotificationWithContext
passes it intogetVAPIDAuthorizationHeader
, and in #45,getVAPIDAuthorizationHeader
used it when forming theexp
claim. However, what looks to have been a faulty merge conflict resolution in #46 seems to have reverted the change ingetVAPIDAuthorizationHeader
, leavingexpiration
unused:As a result, the VAPID JWT expiration is always now+12 hours, even when explicitly set otherwise.
The text was updated successfully, but these errors were encountered: