Simplified swerve sim #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # project/src/main/java/org/ironmaple/simulation/drivesims/SimplifiedSwerveDriveSimulation.java
# Conflicts: # .gitignore # project/src/main/java/org/ironmaple/simulation/MapleMotorSim.java # project/src/main/java/org/ironmaple/simulation/drivesims/SimplifiedSwerveDriveSimulation.java # project/src/main/java/org/ironmaple/simulation/drivesims/SwerveModuleSimulation.java
|
hey, can you make this PR point to motor-sim-control-loops? |
|
it's nice work here, but the newer version of maple-motor-sim is using the CTRE style requests |
|
Done, but there are now a few conflicts in the branch merge, and I don't have write access to resolve them. |
|
thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Before submitting your pull request, please review the following:
Simplified Swerve Simulation Class
Wrapped most of the needed SwerveSimulation parts into a single class for less advanced users, also updated the current SwerveModuleSimulation to use the newer MapleMotorSim. There are probably some missing Javadocs comments, but all the functionality is there, so I can start making a template project.