[API] Motor Sim Overhaul #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GearBoxFox
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
I like it, @catr1xLiu can give the final judgement and merge though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batteries Included Motor Sim!
The goal of this was to provide a motor sim api that is as easy to use as a motor in real life.
Features
TODO
Merge Sooner Rather Than Later
I think having a minimum viable implementation in maple sim with the desired api sooner rather than later is better. All of the todo are modifying stuff the user doesn't touch or new features that wont break existing code using this class.