Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making vn2 use a config file #58

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

SethHollandsworth
Copy link
Owner

Currently there are lots of configuration arguments to be used for VN2. This improves the user experience by being able to check in configuration with git to give more reproducible operations.

@SethHollandsworth SethHollandsworth force-pushed the feature/vn2-config-file branch from 7aef608 to f49f70e Compare August 1, 2024 17:17
Copy link
Collaborator

@ksayid ksayid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SethHollandsworth SethHollandsworth merged commit f49f70e into feature/virtual_kubelet Aug 1, 2024
@SethHollandsworth SethHollandsworth deleted the feature/vn2-config-file branch August 1, 2024 17:52
SethHollandsworth pushed a commit that referenced this pull request Aug 14, 2024
* build: add cicd pipeline (#7)

* build: move update version logic to workflow (#8)

* build: Run CI on multiple python version (#38)

* build: Run CI in Python 3.8-3.11

* build: remove pull request event for CI to avoid duplicate runs

* test: add test cases for commands (#40)

* fix: error when register API with long description spec (#41)

* test: add test cases for optional parameters (#42)

* feat!: remove file name param (#43)

* fix: error not thrown when import spec with >3MB file (#44)

* feat!: remove state param for deployment commands (#46)

* fix: API title created by register command is not same with provided spec (#47)

* feat!: redesign parameters to specify APIM instance for import-from-apim command (#45)

* test: clean up legacy test cases (#48)

* test: add test cases for command examples (#49)

* docs: update help message per feedback (#50)

* build: bump version to 1.0.0 and add changelog (#51)

* fix: some parameters should be required in import-specification and deployment command (#53)

* feat!: rename parameter names to align with other Azure CLI command experience (#52)

* test: enable test for import-from-apim (#54)

* test: fix show service test case (#55)

* docs: update changelog for 1.0.0 (#56)

* Update HISTORY.rst - jukasper

updated changelog

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* docs: update readme for apic-extension (#57)

* fix: cannot run create command against existing resource (#58)

* fix: cannot run create command against existing resource

* style: fix style

* build: remove cicd pipeline (#59)

* build: resolve review comments (#60)

---------

Co-authored-by: Julia Kasper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants