Improve diff mode #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethHollandsworth
requested review from
hgarvison and
stevendongatmsft
as code owners
SethHollandsworth
force-pushed
the
improve_diff_mode
branch
from
2274bbf to
d3666a7
Compare
hgarvison
approved these changes
Mar 22, 2024
ksayid
previously approved these changes
Mar 25, 2024
ksayid
reviewed
Mar 25, 2024
src/confcom/azext_confcom/os_util.py
Outdated
| manifest = load_json_from_file(manifest_path) | ||
| # if we match a RepoTag to the image, stop searching | ||
| for image in manifest: | ||
| if image_name in image.get("RepoTags"): |
There was a problem hiding this comment.
Is there a chance the RepoTags key will be missing from image? I think it'd cause a type error in the if-statement.
That would lead to the manifest.json getting extracted but not cleaned up. A try-finally would help with that I think.
SethHollandsworth
force-pushed
the
improve_diff_mode
branch
from
dfd0e32 to
42ca798
Compare
ksayid
approved these changes
Mar 26, 2024
SethHollandsworth
force-pushed
the
improve_diff_mode
branch
from
ef817dd to
30222af
Compare
hgarvison
reviewed
Mar 27, 2024
hgarvison
approved these changes
Apr 2, 2024
SethHollandsworth
force-pushed
the
improve_diff_mode
branch
from
5c8b8b6 to
06e6177
Compare
SethHollandsworth
pushed a commit
that referenced
this pull request
Aug 14, 2024
* build: add cicd pipeline (#7) * build: move update version logic to workflow (#8) * build: Run CI on multiple python version (#38) * build: Run CI in Python 3.8-3.11 * build: remove pull request event for CI to avoid duplicate runs * test: add test cases for commands (#40) * fix: error when register API with long description spec (#41) * test: add test cases for optional parameters (#42) * feat!: remove file name param (#43) * fix: error not thrown when import spec with >3MB file (#44) * feat!: remove state param for deployment commands (#46) * fix: API title created by register command is not same with provided spec (#47) * feat!: redesign parameters to specify APIM instance for import-from-apim command (#45) * test: clean up legacy test cases (#48) * test: add test cases for command examples (#49) * docs: update help message per feedback (#50) * build: bump version to 1.0.0 and add changelog (#51) * fix: some parameters should be required in import-specification and deployment command (#53) * feat!: rename parameter names to align with other Azure CLI command experience (#52) * test: enable test for import-from-apim (#54) * test: fix show service test case (#55) * docs: update changelog for 1.0.0 (#56) * Update HISTORY.rst - jukasper updated changelog * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * docs: update readme for apic-extension (#57) * fix: cannot run create command against existing resource (#58) * fix: cannot run create command against existing resource * style: fix style * build: remove cicd pipeline (#59) * build: resolve review comments (#60) --------- Co-authored-by: Julia Kasper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff mode now labels differences by the container's given name, not the image name. This allows for clearer messages when multiple containers in a single container group use the same image tag. Additionally, there's a better method to figure out which container was changed assuming it uses the same image.