Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set node by name #73

Merged
merged 22 commits into from
Oct 31, 2024
Merged

Set node by name #73

merged 22 commits into from
Oct 31, 2024

Conversation

ollmer
Copy link
Collaborator

@ollmer ollmer commented Oct 25, 2024

  1. Use names instead of indices in the SetNextNode and everywhere.
  2. Remove node counter logic from the tape view. Compute the next intended node in the agent.
  3. Track the last used node and the last SetNextNode() step in the view
  4. Update all tapes accordingly
  5. Rewrite the node intro in the intro.ipynb

@ollmer ollmer changed the title Set node by name [WIP] Set node by name Oct 28, 2024
@ollmer ollmer changed the title [WIP] Set node by name Set node by name Oct 29, 2024
@ollmer ollmer requested a review from rizar October 29, 2024 12:18
@ollmer
Copy link
Collaborator Author

ollmer commented Oct 29, 2024

@rizar pls pay special attention to the view.py (I've changed it since our last talk, it uses properties instead of methods again) and intro_clean.ipynb (I've rewritten the nodes intro to reflect addressing by name)

Copy link
Collaborator

@rizar rizar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good!

can you please confirm that now control flow steps will remain in the view and should be removed and the time of prompt creation?

tapeagents/prompting.py Show resolved Hide resolved
tapeagents/view.py Outdated Show resolved Hide resolved
examples/intro_clean.ipynb Outdated Show resolved Hide resolved
examples/intro_clean.ipynb Outdated Show resolved Hide resolved
@ollmer ollmer merged commit f884c54 into main Oct 31, 2024
2 checks passed
@ollmer ollmer deleted the set_node_by_name branch October 31, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants