Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify TapeView to allow SetNextNode to be yielded after everything #59

Open
NicolasAG opened this issue Oct 16, 2024 · 2 comments
Open
Assignees

Comments

@NicolasAG
Copy link
Collaborator

As of now, it seems that SetNextNode can be after ToolCalls, but not after Call.
It would be nice to make it consistent and allow SetNextNode after Call as well.

@ollmer
Copy link
Collaborator

ollmer commented Oct 29, 2024

Can you please create a short example illustrating what happens now when we generate SetNextNode after the Call and what the intended behavior looks like?
I've changed the computation of the next node in #73, and I have some doubts that these changes could already solve the problem, but I need a concrete example to check.

@ollmer ollmer self-assigned this Oct 29, 2024
@NicolasAG
Copy link
Collaborator Author

I was looking at the Financial Analyst example at the end of the intro notebook. Particularly inside the generate_steps function of the ActNode. I was wondering if we can change the order of SetNextNode() and AssistantStep(). Just tried it again and it seems to be working regardless of the order...

Screenshot 2024-10-29 at 1 21 27 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants