Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] [#229] use python 3.6 version in all jobs #230

Merged
merged 2 commits into from
Oct 7, 2021
Merged

[Draft] [#229] use python 3.6 version in all jobs #230

merged 2 commits into from
Oct 7, 2021

Conversation

aleksandr-kotlyar
Copy link
Collaborator

@aleksandr-kotlyar aleksandr-kotlyar commented Oct 6, 2021 •
edited
Loading

Closes #229

@aleksandr-kotlyar
[SergeyPirogov#227] download IEDriverServer from SeleniumHQ/selenium …
5a4b11b 
…GitHub releases

- adopt IEDriverServer to be downloaded from SeleniumHQ/selenium GitHub repo release assets instead of https://selenium-release.storage.googleapis.com/
- format indentations and linebreaks in GeckoDriver and IEDriver classes
- format indentations and linebreaks in microsoft.py
@pep8speaks
Copy link

pep8speaks commented Oct 6, 2021 •
edited
Loading

Hello @aleksandr-kotlyar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 107:80: E501 line too long (118 > 79 characters)
Line 178:80: E501 line too long (118 > 79 characters)

Line 15:80: E501 line too long (94 > 79 characters)
Line 16:80: E501 line too long (101 > 79 characters)

Comment last updated at 2021-10-06 03:12:36 UTC

@aleksandr-kotlyar aleksandr-kotlyar force-pushed the gh_#229_python39_to_python36_ci branch 2 times, most recently from f8b279d to a293c7e Compare October 6, 2021 01:12
@aleksandr-kotlyar aleksandr-kotlyar changed the title [#229] use python 3.6 version in all jobs [Draft] [#229] use python 3.6 version in all jobs Oct 6, 2021
@aleksandr-kotlyar aleksandr-kotlyar force-pushed the gh_#229_python39_to_python36_ci branch 3 times, most recently from d0ef3ae to b82e85f Compare October 6, 2021 03:10
@SergeyPirogov SergeyPirogov merged commit bef01eb into SergeyPirogov:master Oct 7, 2021
@aleksandr-kotlyar aleksandr-kotlyar mentioned this pull request Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected Python 3.9 in CI when python 3.6 was setup
3 participants
@aleksandr-kotlyar @pep8speaks @SergeyPirogov