Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download IEDriver from GitHub #227

Closed
aleksandr-kotlyar opened this issue Oct 5, 2021 · 0 comments · Fixed by #228
Closed

Download IEDriver from GitHub #227

aleksandr-kotlyar opened this issue Oct 5, 2021 · 0 comments · Fixed by #228
Assignees
@aleksandr-kotlyar

Comments

@aleksandr-kotlyar
Copy link
Collaborator

aleksandr-kotlyar commented Oct 5, 2021 •
edited
Loading

What

Replace IEDriver source that is not well-supported anymore https://selenium-release.storage.googleapis.com/ as far as we could think from SeleniumHQ/selenium#9824 (comment) comment.
With new source - GitHub Assets of SeleniumHQ/selenium.

Risks & Conclusions

  1. New versions can not be deployed to old sources (because they don't want to fix minor bug from deploy as we have seen in the comment above.
  2. But all old versions seems to be already there - on GitHub Releases https://github.com/SeleniumHQ/selenium/releases

Solution

Move IEDriverServer download to GitHub as far as selenium developers started hosting it there.

@SergeyPirogov what do you think about solution? I have started to make PR

Fixes #221
Fixes #216
Closes #217
aleksandr-kotlyar added a commit to aleksandr-kotlyar/webdriver_manager that referenced this issue Oct 6, 2021
@aleksandr-kotlyar
[SergeyPirogov#227] download IEDriverServer from SeleniumHQ/selenium …
12a2434 
…GitHub releases

- adopt IEDriverServer to be downloaded from SeleniumHQ/selenium GitHub repo release assets instead of https://selenium-release.storage.googleapis.com/
- format indentations and linebreaks in GeckoDriver and IEDriver classes
@aleksandr-kotlyar aleksandr-kotlyar mentioned this issue Oct 6, 2021
Merged
aleksandr-kotlyar added a commit to aleksandr-kotlyar/webdriver_manager that referenced this issue Oct 6, 2021
@aleksandr-kotlyar
[SergeyPirogov#227] download IEDriverServer from SeleniumHQ/selenium …
5e59a81 
…GitHub releases

- adopt IEDriverServer to be downloaded from SeleniumHQ/selenium GitHub repo release assets instead of https://selenium-release.storage.googleapis.com/
- format indentations and linebreaks in GeckoDriver and IEDriver classes
+ format indentations and linebreaks in microsoft.py
aleksandr-kotlyar added a commit to aleksandr-kotlyar/webdriver_manager that referenced this issue Oct 6, 2021
@aleksandr-kotlyar
[SergeyPirogov#227] download IEDriverServer from SeleniumHQ/selenium …
712c680 
…GitHub releases

- adopt IEDriverServer to be downloaded from SeleniumHQ/selenium GitHub repo release assets instead of https://selenium-release.storage.googleapis.com/
- format indentations and linebreaks in GeckoDriver and IEDriver classes
- format indentations and linebreaks in microsoft.py
aleksandr-kotlyar added a commit to aleksandr-kotlyar/webdriver_manager that referenced this issue Oct 6, 2021
@aleksandr-kotlyar
[SergeyPirogov#227] download IEDriverServer from SeleniumHQ/selenium …
5a4b11b 
…GitHub releases

- adopt IEDriverServer to be downloaded from SeleniumHQ/selenium GitHub repo release assets instead of https://selenium-release.storage.googleapis.com/
- format indentations and linebreaks in GeckoDriver and IEDriver classes
- format indentations and linebreaks in microsoft.py
SergeyPirogov pushed a commit that referenced this issue Oct 7, 2021
@aleksandr-kotlyar
[#227] download IEDriverServer from SeleniumHQ/selenium GitHub releas…
9811dce 
…es (#228)

- adopt IEDriverServer to be downloaded from SeleniumHQ/selenium GitHub repo release assets instead of https://selenium-release.storage.googleapis.com/
- format indentations and linebreaks in GeckoDriver and IEDriver classes
- format indentations and linebreaks in microsoft.py
SergeyPirogov pushed a commit that referenced this issue Oct 7, 2021
@aleksandr-kotlyar
[Draft] [#229] use python 3.6 version in all jobs (#230)
bef01eb 
* [#227] download IEDriverServer from SeleniumHQ/selenium GitHub releases

- adopt IEDriverServer to be downloaded from SeleniumHQ/selenium GitHub repo release assets instead of https://selenium-release.storage.googleapis.com/
- format indentations and linebreaks in GeckoDriver and IEDriver classes
- format indentations and linebreaks in microsoft.py

* [#229] use python 3.6 version in all jobs
@aleksandr-kotlyar aleksandr-kotlyar self-assigned this May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleksandr-kotlyar aleksandr-kotlyar

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@aleksandr-kotlyar