Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): update typings for defaultValue & value #4018

Merged
merged 3 commits into from
Aug 4, 2020
Merged

fix(Dropdown): update typings for defaultValue & value #4018

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa079b9
Fixed typing for defaultValue and value
zhongeric Aug 3, 2020
98ffb83
Fixed comment
zhongeric Aug 3, 2020
ee27c0e
Merge branch 'master' into master
layershifter Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/modules/Dropdown/Dropdown.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export interface StrictDropdownProps {
defaultUpward?: boolean

/** Initial value or value array if multiple. */
defaultValue?: string | number | boolean | number | string | boolean[]
defaultValue?: string | number | boolean | (number | string | boolean)[]

/** A dropdown menu can open to the left or to the right. */
direction?: 'left' | 'right'
Expand Down Expand Up @@ -279,7 +279,7 @@ export interface StrictDropdownProps {
trigger?: React.ReactNode

/** Current value or value array if multiple. Creates a controlled component. */
value?: boolean | number | string | boolean | number | string[]
value?: boolean | number | string | (boolean | number | string)[]

/** Controls whether the dropdown will open upward. */
upward?: boolean
Expand Down