Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): update typings for defaultValue & value #4018

Merged
merged 3 commits into from
Aug 4, 2020
Merged

fix(Dropdown): update typings for defaultValue & value #4018

merged 3 commits into from
Aug 4, 2020

Conversation

zhongeric
Copy link
Contributor

Fixed typings issue for defaultValue and value in Dropdown.d.ts

Fixes #4017

Allow arrays of strings, numbers, and booleans instead of just boolean[]
@welcome
Copy link

welcome bot commented Aug 3, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

Merging #4018 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4018   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         185      185           
  Lines        3251     3251           
=======================================
  Hits         3246     3246           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc2fd4c...ee27c0e. Read the comment docs.

@layershifter layershifter changed the title Fix #4017 fix(Dropdown): update typings for defaultValue & value Aug 4, 2020
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@layershifter layershifter merged commit b0170ff into Semantic-Org:master Aug 4, 2020
@welcome
Copy link

welcome bot commented Aug 4, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: multiple defaultValue & value have incorrect types
3 participants