feat(Dimmer): add transition #2001
Conversation
…React into feat/dimmer-transition
|
Very cool, can't wait to get Transitions in the entire framework :) This is largely what is stopping a v1 release. The other blocking work is minor in comparison. |
|
I have been scratching my head over the dimmer transitions used in the docs site, can't wait for this! |
|
It would be great if we tackled #837 and made import React from 'react'
import Transition from './modules/Transition/Transition'
const withTransition = Component => {
const WithTransition = props => {
const { transition } = props
const element = <Component {...props} />
if (!transition) return element
return Transition.create(transition, {
defaultProps: {
...props,
children: element,
},
})
}
return WithTransition
}This requires adding a shorthand factory to the Then, in our component files: // Button.js
export default withTransition(Button)Now, we can do this: <Button transition='fade' />
<Button transition={{ animation: 'fade', duration: 100 }} />I actually did this for |
|
In fact, the key problem that I see there is with |
|
Needs #2155. |
|
TransitionablePortal has been merged, unblocking this. |
|
New to this site, and Im hoping this is the right place to post this. Im looking for a a menu with an animated (transition?) dropdown, that has a delay on mouseout. ANy ideas where i can find or is this too much to ask in the SemanticUI/React world? |
|
@padrefuture animations are a work in progress here in the React port of Semantic UI. That feature is not yet available. We do have a Transition component. That component needs to be integrated into our components so we have the transitions you are looking for. PRs welcome! |
|
Am I wrong or is just a linting problem the latest ci/circleci problem? Can we force this and then fix the lint problems? I'm newbie, sorry for maybe wrong questions. |
Codecov Report
@@ Coverage Diff @@
## master #2001 +/- ##
=========================================
+ Coverage 99.74% 99.8% +0.06%
=========================================
Files 160 149 -11
Lines 2751 2595 -156
=========================================
- Hits 2744 2590 -154
+ Misses 7 5 -2
Continue to review full report at Codecov.
|
|
I've merged master and fixed the lint issues. This PR still appears to be in progress, as the description states. We'll need the feature completed, some tests, and some docs. |
|
Hey guys. Any success with @levithomason 's sugestion? I don't see myself moving away from semantic ui react just because of a simple animation. This css framework is awesome for react. someone do something please |
|
Good morning @jermsam This is an open source project and anyone is welcome to contribute. If there is an area of the framework where you have a need for something specific to your project, pull requests are always welcome. |
|
There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one. However, PRs for this issue will of course be accepted and welcome! If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks! |
|
@Stale, please, shut up. |
|
There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one. However, PRs for this issue will of course be accepted and welcome! If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks! |
|
There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one. However, PRs for this issue will of course be accepted and welcome! If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks! |
WIP