Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal doesn't support animations #1054

Closed
nix1 opened this issue Dec 19, 2016 · 3 comments
Closed

Modal doesn't support animations #1054

nix1 opened this issue Dec 19, 2016 · 3 comments

Comments

@nix1
Copy link

nix1 commented Dec 19, 2016

Steps

Open a modal.

Expected Result

The modal doesn't animate while opening.

Actual Result

The modal shows immediately, without any animation.

Version

0.62.3
@levithomason
Copy link
Member

No transitions are included until #813 is merged.

@completer
Copy link

completer commented Aug 31, 2017 •
edited
Loading

Now <Transition /> is done, should <Modal /> have animation by default? Or do we need to enable it?

@levithomason
Copy link
Member

Now that Transition is complete, it needs to be integrated into our own components. The Dimmer is getting transitions added in #2001.

Perhaps you could submit a PR for the modal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@completer @nix1 @levithomason