Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Removing the 'ELEMENT' key when serialising RemoteWebElement to Json #9293

Closed
wants to merge 1 commit into from

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixes #6393

Motivation and Context

The changes remove the legacy pointer 'ELEMENT' while serialising the RemoteWebElement to Json. This aligns with the Webdrive spec https://w3c.github.io/webdriver/#dfn-web-element-identifier
"The JSON serialization of an element is a JSON Object where the web element identifier key is mapped to the element’s web element reference."
"The web element identifier is the string constant "element-6066-11e4-a52e-4f735466cecf".

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani force-pushed the remove-element-key branch from 874c34d to 50a1a91 Compare March 18, 2021 05:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diemol diemol added the C-java label Mar 29, 2021
@shs96c
Copy link
Member

shs96c commented Jun 3, 2021

I'd rather leave this in until we figure out how to disentangle the JWP from the W3C protocols, while still offering people backwards compat through the server if they need it.

@titusfortner
Copy link
Member

I don't think we'll get to this until/unless we completely revamp the Java code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of legacy ELEMENT pointer origin for actions
4 participants