-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of legacy ELEMENT pointer origin for actions #6393
Comments
As discussed in IRC, ETA of Selenium 4 |
Looking at how we're doing this, I'm not sure we can remove this before removing the entire handshake code. I'm running the tests so we can see - https://github.com/SeleniumHQ/selenium/actions/runs/2799798464 |
@diemol when I'm suggesting we don't have good OSS tests to ensure handshake is working... I'm pretty sure this branch should have a bunch of failures, but everything is passing. |
This was implemented by #11823 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Geckodriver currently needs a fallback for deserializing the pointer origin because at least the Java implementation is still using the legacy
ELEMENT
identifier for pointer move primitives. Here an excerpt from the trace log:This is not used by other bindings like Python anymore, and Java should also drop that at some point. @barancev and @shs96c, not sure when you actually want to do that?
As long as this hasn't been done we will keep the fallback in geckodriver.
The text was updated successfully, but these errors were encountered: