Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of legacy ELEMENT pointer origin for actions #6393

Closed
whimboo opened this issue Sep 11, 2018 · 5 comments
Closed

Remove usage of legacy ELEMENT pointer origin for actions #6393

whimboo opened this issue Sep 11, 2018 · 5 comments
Labels
C-java help wanted Issues looking for contributions

Comments

@whimboo
Copy link
Contributor

whimboo commented Sep 11, 2018

Geckodriver currently needs a fallback for deserializing the pointer origin because at least the Java implementation is still using the legacy ELEMENT identifier for pointer move primitives. Here an excerpt from the trace log:

        {
          "duration": 100,
          "x": 0,
          "y": 0,
          "type": "pointerMove",
          "origin": {
            "ELEMENT": "cbd0b1e7-a456-4730-bf2b-b8ba7ec6aba1",
            "element-6066-11e4-a52e-4f735466cecf": "cbd0b1e7-a456-4730-bf2b-b8ba7ec6aba1"
          }
        },

This is not used by other bindings like Python anymore, and Java should also drop that at some point. @barancev and @shs96c, not sure when you actually want to do that?

As long as this hasn't been done we will keep the fallback in geckodriver.

@lmtierney
Copy link
Member

As discussed in IRC, ETA of Selenium 4

@diemol diemol added the help wanted Issues looking for contributions label Oct 17, 2021
@titusfortner titusfortner added this to the 4.3 milestone May 13, 2022
@diemol diemol modified the milestones: 4.3, 4.4 Jun 24, 2022
@titusfortner
Copy link
Member

Looking at how we're doing this, I'm not sure we can remove this before removing the entire handshake code. I'm running the tests so we can see - https://github.com/SeleniumHQ/selenium/actions/runs/2799798464

@titusfortner
Copy link
Member

@diemol when I'm suggesting we don't have good OSS tests to ensure handshake is working... I'm pretty sure this branch should have a bunch of failures, but everything is passing.

@diemol diemol modified the milestones: 4.4, 4.5 Aug 15, 2022
@titusfortner titusfortner removed this from the 4.5 milestone Sep 14, 2022
@diemol
Copy link
Member

diemol commented May 5, 2023

This was implemented by #11823

@diemol diemol closed this as completed May 5, 2023
Copy link

github-actions bot commented Dec 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-java help wanted Issues looking for contributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants