Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Restore Closure Java classes required for JavaScript build #10785

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

bonigarcia
Copy link
Member

Description

PR #10778 deleted by mistake a Java package required by the JavaScript build, and as a result, the JavaScript build started to fail. This PR restores these files.

Motivation and Context

Migration of Java tests to JUnit 5 (issue #10196).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR SeleniumHQ#10778 deleted by mistake a Java package required by the JavaScript
build, and as a result, the JavaScript build started to fail. This PR
restores these files
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bonigarcia!

@diemol diemol merged commit a268142 into SeleniumHQ:trunk Jun 20, 2022
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
…leniumHQ#10785)

PR SeleniumHQ#10778 deleted by mistake a Java package required by the JavaScript
build, and as a result, the JavaScript build started to fail. This PR
restores these files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants