[java] Migrate all tests to JUnit Jupiter (JUnit 5) (issue #10196) #10778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonigarcia
force-pushed
the
junit5-migration
branch
from
b042ca1 to
0165e72
Compare
bonigarcia
force-pushed
the
junit5-migration
branch
from
0165e72 to
9226922
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
bonigarcia
added a commit
to bonigarcia/selenium
that referenced
this pull request
Jun 20, 2022
PR SeleniumHQ#10778 deleted by mistake a Java package required by the JavaScript build, and as a result, the JavaScript build started to fail. This PR restores these files
8 tasks
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
…#10196) (SeleniumHQ#10778) [java] Migrate all tests to JUnit Jupiter (JUnit 5) Co-authored-by: Diego Molina <[email protected]>
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
…leniumHQ#10785) PR SeleniumHQ#10778 deleted by mistake a Java package required by the JavaScript build, and as a result, the JavaScript build started to fail. This PR restores these files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates all the Selenium tests from JUnit 4 to JUnit 5.
For that, the scaffolding test classes based on JUnit 4 (such as JUnit4TestBase, SeleniumTestRunner, or SeleniumTestRule) has been reimplemented as a new test base (called
JupiterTestBase) and a JUnit 5 extension (calledSeleniumExtension). Then, all the existing tests using the formerJUnit4TestBasehave been migrated to use the new base class and the new JUnit 5 programming model (i.e., Jupiter).Motivation and Context
Solves #10196 (migration to JUnit 5).
Types of changes
Checklist