Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Adding port to nodes service #1996

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Nov 6, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

feat: Adding ports to nodes service

Motivation and Context

  • Bumping chart version 0.24.0
  • Update image tag in chart to 4.15.0-20231102
  • Add [🚀 Feature]: Adding port to nodes service #1995
    • Extra ports exposed in node service can be added via edgeNode.service.ports, firefoxNode.service.ports, chromeNode.service.ports

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VietND96 VietND96 changed the title Bumping chart version feat: Adding port to nodes service Nov 7, 2023
Signed-off-by: Viet Nguyen Duc <[email protected]>
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VietND96!

@diemol diemol merged commit fe17f6d into SeleniumHQ:trunk Nov 8, 2023
4 checks passed
@VietND96 VietND96 linked an issue Nov 28, 2023 that may be closed by this pull request
@VietND96 VietND96 changed the title feat: Adding port to nodes service feat(chart): Adding port to nodes service Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Adding port to nodes service
2 participants