Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Adding port to nodes service #1995

Closed
piotrlaczykowski opened this issue Nov 6, 2023 · 8 comments · Fixed by #1996
Closed

[🚀 Feature]: Adding port to nodes service #1995

piotrlaczykowski opened this issue Nov 6, 2023 · 8 comments · Fixed by #1996

Comments

@piotrlaczykowski
Copy link

Feature and motivation

Hello,
you gave us an option to open a port for pods. Can you also add this option for service?

Usage example

We added SSH to our chrome/edge-nodes and there is no option to use it without port opening in service.

Copy link

github-actions bot commented Nov 6, 2023

@grubyhs, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

Copy link

github-actions bot commented Nov 6, 2023

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

@VietND96
Copy link
Member

VietND96 commented Nov 6, 2023

Hi, can you confirm that your requirements will have the outcomes something like
values.yaml

edgeNode:
  ports:
    - 22

selenium-grid/templates/edge-node-service.yaml

apiVersion: v1
kind: Service
metadata:
  name: selenium-edge-node
...
spec:
  type: ClusterIP  # or NodePort or LoadBalancer
  ports:
    - port: 22
      targetPort: 22
      # nodePort: 30xxx

@piotrlaczykowski
Copy link
Author

Hi, can you confirm that your requirements will have the outcomes something like values.yaml

edgeNode:
  ports:
    - 22

selenium-grid/templates/edge-node-service.yaml

apiVersion: v1
kind: Service
metadata:
  name: selenium-edge-node
...
spec:
  type: ClusterIP  # or NodePort or LoadBalancer
  ports:
    - port: 22
      targetPort: 22
      # nodePort: 30xxx

That's my point :) You can also add an option to choose what type of service will be used.

VietND96 added a commit to NDViet/docker-selenium that referenced this issue Nov 7, 2023

Verified

This commit was signed with the committer’s verified signature.
VietND96 Viet Nguyen Duc
Signed-off-by: Viet Nguyen Duc <[email protected]>
@VietND96
Copy link
Member

VietND96 commented Nov 7, 2023

I added this via PR #1996. Can you take a look also?

diemol pushed a commit that referenced this issue Nov 8, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Bumping chart version

Signed-off-by: Viet Nguyen Duc <[email protected]>

* #1995 feat: Adding port to nodes service

Signed-off-by: Viet Nguyen Duc <[email protected]>

* Update chart CHANGELOG

Signed-off-by: Viet Nguyen Duc <[email protected]>

---------

Signed-off-by: Viet Nguyen Duc <[email protected]>
@VietND96
Copy link
Member

VietND96 commented Nov 9, 2023

PR #1996 is delivered in chart version 0.24.0

@diemol
Copy link
Member

diemol commented Nov 9, 2023

Thank you, @VietND96!

@diemol diemol closed this as completed Nov 9, 2023
@VietND96 VietND96 linked a pull request Nov 28, 2023 that will close this issue
8 tasks
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants