Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment variable naming in README #1761

Merged
merged 1 commit into from
Jan 3, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -844,12 +844,12 @@ captured in the same video.
[Chrome](https://developers.google.com/web/updates/2017/04/headless-chrome),
When using headless mode, there's no need for the [Xvfb](https://en.wikipedia.org/wiki/Xvfb) server to be started.

To avoid starting the server you can set the `SE_START_XVFB` environment variable to `false`
To avoid starting the server you can set the `START_XVFB` environment variable to `false`
(or any other value than `true`), for example:

``` bash
$ docker run -d --net grid -e SE_EVENT_BUS_HOST=selenium-hub -e SE_EVENT_BUS_PUBLISH_PORT=4442 \
-e SE_EVENT_BUS_SUBSCRIBE_PORT=4443 -e SE_START_XVFB=false --shm-size="2g" selenium/node-chrome:4.7.2-20221219
-e SE_EVENT_BUS_SUBSCRIBE_PORT=4443 -e START_XVFB=false --shm-size="2g" selenium/node-chrome:4.7.2-20221219
```

For more information, see this GitHub [issue](https://github.com/SeleniumHQ/docker-selenium/issues/567).
Expand Down Expand Up @@ -1204,7 +1204,7 @@ or

`Message: unknown error: Chrome failed to start: exited abnormally`

The reason _might_ be that you've set the `SE_START_XVFB` environment variable to "false", but forgot to
The reason _might_ be that you've set the `START_XVFB` environment variable to "false", but forgot to
actually run Firefox, Chrome or Edge in headless mode.

### Mounting volumes to retrieve downloaded files
Expand Down