Fix environment variable naming in README #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
no-reply
pushed a commit
to surfliner/surfliner-mirror
that referenced
this pull request
Mar 7, 2023
> setting only SE_START_XVFB to false has no effect SeleniumHQ/docker-selenium#1761 (˚Õ˚)ر ~~~~╚╩╩╝
prashanth-volvocars
pushed a commit
to prashanth-volvocars/docker-selenium
that referenced
this pull request
Jun 29, 2023
tksjh
reviewed
Oct 25, 2023
There was a problem hiding this comment.
this commit should be reverted?
START_XVFB is not set in dockerfile since 59cf4f7
selenium already depends on SE_START_XVFB since SeleniumHQ/selenium@5571415
|
@tksjh that's correct. Would you like to send a PR for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the environment variable
SE_START_XVFBtoSTART_XVFBin the README.Motivation and Context
The “temporal fix” introduced in #1610 sets both variables
SE_START_XVFBandSTART_XVFB. SinceSE_START_XVFBis used only as a fallback forSTART_XVFB(i.e., it is evaluated only ifSTART_XVFBis null or unset) in this repository’s shell scripts, setting onlySE_START_XVFBtofalsehas no effect, and overwritingSTART_XVFBis required. As suggested here, the best way to handle this issue for now is to update the README.Types of changes
Checklist