-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds build steps in makefile for building Chrome and Firefox betas #1658
Conversation
…ndalone from the makefile.
I also marked this as a draft pull request since it will be easier to merge #1656 before making the full set of changes for automatically building Chrome and Firefox betas... |
Here is a test release that shows what the release notes might look like. https://github.com/jamesmortensen/docker-selenium/releases/tag/4.4.0-20220816. I limited the beta tag to only being placed on the 4.4.0-20220816-beta "grid and build date" tag. Also, the release notes include the hash from Docker Hub as well. Please let me know if there's any changes needed to the release notes or tags, and I'll move the necessary from the "test-beta-deploy" branch to the PR branch. (Some modifications to perform the test as "jamesmortensen1" need to be removed prior to merging this.) |
… the Base/Dockerfile.
… accidentally deleted standalone_edge...
…owsers. Also, retagging node-base and hub as dev/beta to make the testing process easier.
…ion if the one for dev is not available. Also, added matrix strategy with fail-fast false to build, test, and deploy whatever platforms pass testing.
…ing the logic on this
…r to testing, so adding SKIP_BUILD argument from seleniarm repo. Adding deploy steps.
…d testing. Output browser and driver versions in the logs
fixes #1286 |
I just realized the docs may need to be updated. Just FYI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jamesmortensen! This is great!
We can have a separate PR for the README to briefly document the existence of these images.
Build steps to build Chrome Beta and Firefox Beta nodes and standalone from the makefile. Fixes #1286
Description
When running
make build
, all of the images will be built, including four more additional images:Beta images can also be built using
make chrome_beta
andmake standalone_chrome_beta
and so forth.The tag '-beta' is added to the end of the build date. For instance, selenium/node-chrome:20220815-beta
Motivation and Context
Some community members want to run tests on up and coming versions of these browsers so they can be more informed when a change in the browser code may affect their application. This first step makes it easier for users to build the images themselves and paves the way for these images to be deployed to Docker Hub via the CI pipeline.
Types of changes
Checklist
I've marked this as a draft PR as more work needs to be done to complete it.