-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified make build process to use --build-arg instead of generate.sh scripts, eliminating the templates. #1656
Conversation
… scripts. Removed unneeded txt files and sh files.
I see there's some conflicts. I'll work to resolve them as soon as I can. |
…ges using the Docker SDK for Python
… the Standalone browser container images. Resolved a warning caused by the Base and video Dockerfiles not needing the FROM_IMAGE_ARGS.
The tests in GitHub Actions now pass, and conflicts are resolved. Please let me know if there's anything else we should change. Otherwise, I feel this is good to go. Since the changes were all internal to the Makefile, and since the arguments to the make build process are still the same, I don't think any changes to the README or docs are necessary. Please let me know if that's not the case. |
I want to add that changes to test.py were required. test.py rebuilds containers using the Docker SDK for Python, and this required the new build arguments passed into the SDK build method. This required the following additional changes:
My goal was to make it as easy as possible to maintain. For instance, if we ever add Opera back, or WebKit, then the regular expression would be changed from |
Any reason why this is now a draft? Looked good to me. |
@diemol I wanted to validate that none of my changes affected the deploy process. I haven't done that yet, but if you think it is good to go, then we can merge. |
Test deployment looks good. I think we're ready to merge: https://github.com/jamesmortensen/docker-selenium/releases/tag/4.4.0-20220817 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jamesmortensen! This is great!
This PR takes advantage of the dynamic image feature where we pass in the namespace, version, authors, and in some instances, the base image to be used as the FROM argument, and fixes #1649
Description
Motivation and Context
This reduces the amount of files needed for the build process, and it simplifies the lines of code in the Makefile. It also eliminates commits to auto-generated files, which also eliminates unneeded conflicts when syncing forks.
Types of changes
Checklist