Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] add support of loadBalancerIP for hub and router services #1589

Merged
merged 4 commits into from
Jul 12, 2022
Merged

[helm] add support of loadBalancerIP for hub and router services #1589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb01140
[helm] add support of loadBalancerIP for hub and router services
DANic-git Jun 1, 2022
52766d0
update CHANGELOG.md and bump chart version
DANic-git Jul 8, 2022
2317c15
Update charts/selenium-grid/CHANGELOG.md
diemol Jul 12, 2022
1eb8256
Update charts/selenium-grid/Chart.yaml
diemol Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions charts/selenium-grid/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

All notable changes to this helm chart will be documented in this file.

## :heavy_check_mark: 0.8.0

### Added
- Added support of loadBalancerIP for hub and router services

## :heavy_check_mark: 0.7.0

### Added
Expand Down
2 changes: 1 addition & 1 deletion charts/selenium-grid/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v2
name: selenium-grid
description: A Helm chart for creating a Selenium Grid Server in Kubernetes
type: application
version: 0.7.0
version: 0.8.0
appVersion: 4.3.0-20220706
icon: https://github.com/SeleniumHQ/docker-selenium/raw/trunk/logo.png
2 changes: 2 additions & 0 deletions charts/selenium-grid/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ You can configure the Selenium Hub with this values:
| `hub.extraEnvFrom` | `nil` | Custom environment variables for selenium taken from `configMap` or `secret`-hub |
| `hub.resources` | `{}` | Resources for selenium-hub container |
| `hub.serviceType` | `NodePort` | Kubernetes service type (see https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types) |
| `hub.loadBalancerIP` | `nil` | Set specific loadBalancerIP when serviceType is LoadBalancer (see https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer) |
| `hub.serviceAnnotations` | `{}` | Custom annotations for Selenium Hub service |


Expand All @@ -185,6 +186,7 @@ If you implement selenium-grid with separate components (`isolateComponents: tru
| `components.router.readinessProbe` | `See values.yaml` | Readiness probe settings |
| `components.router.resources` | `{}` | Resources for router container |
| `components.router.serviceType` | `NodePort` | Kubernetes service type (see https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types) |
| `components.router.loadBalancerIP` | `nil` | Set specific loadBalancerIP when serviceType is LoadBalancer (see https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer) |
| `components.router.serviceAnnotations` | `{}` | Custom annotations for router service |
| `components.router.tolerations` | `[]` | Tolerations for router pods |
| `components.router.nodeSelector` | `{}` | Node Selector for router pods |
Expand Down
3 changes: 3 additions & 0 deletions charts/selenium-grid/templates/hub-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ spec:
selector:
app: selenium-hub
type: {{ .Values.hub.serviceType }}
{{- if and (eq .Values.hub.serviceType "LoadBalancer") ( .Values.hub.loadBalancerIP ) }}
loadBalancerIP: {{ .Values.hub.loadBalancerIP }}
{{- end }}
ports:
- name: http-hub
protocol: TCP
Expand Down
3 changes: 3 additions & 0 deletions charts/selenium-grid/templates/router-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ spec:
selector:
app: selenium-router
type: {{ .Values.components.router.serviceType }}
{{- if and (eq .Values.components.router.serviceType "LoadBalancer") (.Values.components.router.loadBalancerIP) }}
loadBalancerIP: {{ .Values.components.router.loadBalancerIP }}
{{- end }}
ports:
- name: tcp-router
protocol: TCP
Expand Down
4 changes: 4 additions & 0 deletions charts/selenium-grid/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ components:
resources: {}
# Kubernetes service type (see https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types)
serviceType: ClusterIP
# Set specific loadBalancerIP when serviceType is LoadBalancer (see https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer)
loadBalancerIP: ""
# Custom annotations for router service
serviceAnnotations: {}
# Tolerations for router pods
Expand Down Expand Up @@ -273,6 +275,8 @@ hub:
resources: {}
# Kubernetes service type (see https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types)
serviceType: ClusterIP
# Set specific loadBalancerIP when serviceType is LoadBalancer (see https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer)
loadBalancerIP: ""
# Custom annotations for Selenium Hub service
serviceAnnotations: {}
# Tolerations for selenium-hub pods
Expand Down