Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] add support of loadBalancerIP for hub and router services #1589

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

DANic-git
Copy link
Contributor

Description

Templates under charts/selenium-grid/templates/hub-service.yaml and charts/selenium-grid/templates/router-service.yaml are updated to support loadBalancerIP value
Values under charts/selenium-grid/values.yaml is updated to support loadBalancerIP value
Readme under charts/selenium-grid/README.md is updated to describe new values

Motivation and Context

This PR adds support to the loadBalancerIP parameter when the service type is LoadBalancer. This allows using of a specific IP for some cloud providers and on-premises

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2022

CLA assistant check
All committers have signed the CLA.

@diemol
Copy link
Member

diemol commented Jun 15, 2022

@den-is any chance you could help us to review this PR?

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update your fork and also update the values in Chart.yaml?

@DANic-git DANic-git force-pushed the helm-add-loadbalancerip branch from c0d3bbe to 032cce8 Compare July 3, 2022 11:03
@DANic-git
Copy link
Contributor Author

Could you please update your fork and also update the values in Chart.yaml?

Sorry for long answer
Updated from upstream

@DANic-git
Copy link
Contributor Author

Could you please update your fork and also update the values in Chart.yaml?

Values in Chart.yaml ?
Now is

apiVersion: v2
name: selenium-grid
description: A Helm chart for creating a Selenium Grid Server in Kubernetes
type: application
version: 0.6.2
appVersion: 4.3.0-20220628
icon: https://github.com/SeleniumHQ/docker-selenium/raw/trunk/logo.png

Do you mean up version?

@diemol
Copy link
Member

diemol commented Jul 7, 2022

Yes the version and also the CHANGELOG please, so we can do a release after merging.

@DANic-git DANic-git force-pushed the helm-add-loadbalancerip branch from 032cce8 to 52766d0 Compare July 8, 2022 06:30
@DANic-git
Copy link
Contributor Author

Yes the version and also the CHANGELOG please, so we can do a release after merging.

Done

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @germetist!

Minor changes, but I can do them myself.

charts/selenium-grid/CHANGELOG.md Outdated Show resolved Hide resolved
charts/selenium-grid/Chart.yaml Outdated Show resolved Hide resolved
@diemol diemol merged commit ed86437 into SeleniumHQ:trunk Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants