-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm] add support of loadBalancerIP for hub and router services #1589
Conversation
@den-is any chance you could help us to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update your fork and also update the values in Chart.yaml
?
c0d3bbe
to
032cce8
Compare
Sorry for long answer |
Values in
Do you mean up |
Yes the version and also the CHANGELOG please, so we can do a release after merging. |
032cce8
to
52766d0
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @germetist!
Minor changes, but I can do them myself.
Description
Templates under
charts/selenium-grid/templates/hub-service.yaml
andcharts/selenium-grid/templates/router-service.yaml
are updated to support loadBalancerIP valueValues under
charts/selenium-grid/values.yaml
is updated to support loadBalancerIP valueReadme under
charts/selenium-grid/README.md
is updated to describe new valuesMotivation and Context
This PR adds support to the
loadBalancerIP
parameter when the service type is LoadBalancer. This allows using of a specific IP for some cloud providers and on-premisesTypes of changes
Checklist