Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to mount extra volumes into nodes pods #1569

Closed
wants to merge 7 commits into from
Closed

Add ability to mount extra volumes into nodes pods #1569

wants to merge 7 commits into from

Conversation

den-is
Copy link
Contributor

@den-is den-is commented May 10, 2022

Description

Added ability to mount arbitrary extra volumes into Chrome, Firefox and Edge nodes.

Motivation and Context

I was testing some of my applications and in parallel decided to run Selenium Hub in my Kubernetes cluster.
Selenium test code downloads files from web-app and shared caller-script had to check files integrity.
It was easy, when I was running simple selenium containers on my localhost and mounting the required Dir into the container.
In the case of Kubernetes same problem is solved using Volumes and VolumeMounts.

My change is strictly following Kubernetes mounts and volumes definitions and accepts exactly the same format as it is described in Kubernetes docs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented May 10, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ den-is
❌ selenium-ci
You have signed the CLA already but the status is still pending? Let us recheck it.

@den-is den-is changed the title Added ability to mount extra volumes into nodes pods Add ability to mount extra volumes into nodes pods May 10, 2022
@den-is
Copy link
Contributor Author

den-is commented May 29, 2022

hey @diemol
I'm going to close that PR because I've messed with the commit email address and am unable to fix it.
Can you please completely remove it from the Github?

I'm going to create duplicate PR with the correct info.
Will you be able to merge it if I supply it with the correct Chart version and changelog?
I was going to wait for #1562 but looks like guy has no time and still has to re-sync his work.

@den-is den-is closed this May 29, 2022
@lorantalas
Copy link
Contributor

@den-is I'm awaiting review, I have time to rebase for sure, it's a matter of minutes. But I don't see the point to do it before the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants