Add ingress resource, use ClusterIP by default #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
can you please add this little config to ingress object too: {{- if .Values.ingress.ingressClassName }}
ingressClassName: {{ .Values.ingress.ingressClassName }}
{{- end }}
rules:
...? |
|
This needs to be rebased, also hoping that @ilpianista has some time to review it. |
This was referenced May 29, 2022
|
@den-is I added an option to set IngressClassName, custom annotations, TLS, and some standard precautions against different Kubernetes API versions. |
Set ClusterIP service type for Hub and Router components, NodePort could be set explicitly, but the default is ClusterIP. Add enabled by default ingress resource, which exposes either Hub or Router service. In the case of LoadBalancer or NodePort set explicitly, you shall turn off ingress explicitly as well. To turn off: --set ingress.enabled=false End-user shall supply the hostname for the ingress. There is an option to use an empty host instead. Be aware of the consequences of accepting traffic from all hosts. Fixes SeleniumHQ#1546
@diemol I rebased. Awaiting for review. |
diemol
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
I am going to merge this and release a new chart so we can use these changes, hopefully you can be around as my helm is a bit rusty, in case issues are reported.
Thank you, @lorantalas!
|
@diemol if the issue is reported please ping me in the comments. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set ClusterIP service type for Hub and Router components, NodePort could be set explicitly, but the default is ClusterIP.
Add enabled by default ingress resource, which exposes either Hub or Router service.
In the case of LoadBalancer or NodePort set explicitly, you shall turn off ingress explicitly as well.
To turn off:
--set ingress.enabled=falseEnd-user shall supply the hostname for the ingress. There is an option to use an empty host instead.
Be aware of the consequences of accepting traffic from all hosts.
Motivation and Context
See issue #1546.
Types of changes
Checklist