Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix healthcheck endpoints #1534

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Fix healthcheck endpoints #1534

merged 1 commit into from
Mar 31, 2022

Conversation

ilpianista
Copy link
Contributor

Description

Fixes #1529

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ilpianista!

@diemol diemol merged commit c38937c into SeleniumHQ:trunk Mar 31, 2022
@ilpianista ilpianista deleted the bugfix/helm-healthchecks branch April 1, 2022 07:27
@kmcrawford
Copy link

I have a router that is not responding but the /readyz is still returning a 200 and thus not restarting to fix the issue.

image

Below is the most common exception in the logs: (I have hours of logs in FINE mode if needed)
Expected to read a START_MAP but instead have: END

@diemol
Copy link
Member

diemol commented May 26, 2022

I think I asked in the other issue if it was possible to see the full stacktrace of the error.

@kmcrawford
Copy link

@diemol There is no smoking gun in the logs, and there is a limit in Github for me to post the logs. Can I send you the logs another method?

@diemol
Copy link
Member

diemol commented Jun 27, 2022

OK, seems you are having this issue #1507 and probably this one too #1605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: HelmChart should use /readyz endpoint to check the health - so that k8s can restart a failed grid
3 participants