Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: HelmChart should use /readyz endpoint to check the health - so that k8s can restart a failed grid #1529

Closed
Bjego opened this issue Mar 24, 2022 · 3 comments · Fixed by #1534

Comments

@Bjego
Copy link

Bjego commented Mar 24, 2022

What happened?

The Http statuscodes for the /readyz endpoint have been adjusted (SeleniumHQ/selenium#10391). The status endpoint as you can see in the Selenium ticket returns always 200 - Ok even if the grid isn't running properly.

We should adjust the helmchart to use the readyz endpoint for health checks. So that kubernetes can restart the grid on it's own.

https://github.com/SeleniumHQ/docker-selenium/blob/trunk/chart/selenium-grid/values.yaml#L199

Command used to start Selenium Grid with Docker

Helm deployment

Relevant log output

non

Operating System

Linux

Docker Selenium version (tag)

Latest helm chart

@diemol
Copy link
Member

diemol commented Mar 25, 2022

@Bjego, would you like to help us with a PR?

Probably @ilpianista can help us by reviewing it.

@Bjego
Copy link
Author

Bjego commented Mar 25, 2022

@Bjego, would you like to help us with a PR?

Probably @ilpianista can help us by reviewing it.

I think I can give it a quick shot, do all components expose the /readyz endpoint?

@Bjego
Copy link
Author

Bjego commented Apr 1, 2022

Guess I'm too late. Was busy this week doing features at work. Thanks for implementing it!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants