feat: 🎸 Fixes submit button, reset button, helper text behavior #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20BBrown14
reviewed
Jan 25, 2021
natedean
approved these changes
Jan 25, 2021
| Object.entries(validationSchema).reduce((acc, [key, value]) => { | ||
| if (value._exclusive?.required) { | ||
| return {...acc, [key]: 'Required'}; | ||
| } |
There was a problem hiding this comment.
It'd be totally cool to mutate the acc here, rather than creating the new object literal and returning it. Ever so slightly more performant, arguably easier to read.
caleboleary
approved these changes
Jan 26, 2021
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the large PR but I didn't want to split this up into multiple PR's because each would be its own version that would introduce new bugs. The re-work required all of this work to be together. Also of note, no breaking changes were needed.
This PR closes 3 issues, possibly more when I go through the issues to see if they are related.
It Fixes the submit button to be disabled when it shouldn't. Fixes the reset
button to reset to the proper initial errors state. Fixes the helper
text to always be in a correct state.
This PR doesn't affect the buttons on the Stepper component. Those buttons do not use the useSQButton hook because the Stepper component has to account for all the steps and forms as a whole.
In addition to the loom explanations, the Date picker and DateTimePicker were not properly rendering the helper text error icon when in the error state. This PR fixes that slight UI issue as well.
Looms:
https://www.loom.com/share/bb878c53cfb447c38ac144bcab0c8ef0
https://www.loom.com/share/7faa684ed86247248cd419ac7b65b026
https://www.loom.com/share/9a5d63dbaed045f3a42403b90a047298
✅ Closes: #59, #83, #47