Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQForm Required field isn't always fulfilled correctly #47

Closed
SeanGroff opened this issue Jan 4, 2021 · 0 comments
Closed

SQForm Required field isn't always fulfilled correctly #47

SeanGroff opened this issue Jan 4, 2021 · 0 comments
Assignees
@SeanGroff
Labels
bug Something isn't working in progress

Comments

@SeanGroff
Copy link
Contributor

After digging into this issue with @chris-boyle-sq on the auto complete component I believe we need to change how we are calculating the isRequired and isFulfilled values.

Moving away from isTouched in favor of a field value for isRequired and isFulfilled makes a lot of sense.
@SeanGroff SeanGroff self-assigned this Jan 4, 2021
@SeanGroff SeanGroff added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jan 4, 2021
SeanGroff pushed a commit that referenced this issue Jan 25, 2021
feat: 🎸 Fixes submit button, reset button, helper text behavior
bc55e62 
Fixes the submit button be disabled when it shouldn't. Fixes the reset
button to reset to the proper initial errors state. Fixes the helper
text to always be in a correct state.

✅ Closes: #59, #83, #47
@SeanGroff SeanGroff mentioned this issue Jan 25, 2021
Merged
SeanGroff pushed a commit that referenced this issue Jan 26, 2021
@semantic-release-bot
chore(release): 2.10.0 [skip ci]
03940c5 
## [2.10.0](v2.9.0...v2.10.0) (2021-01-26)

### Features

* 🎸 Fixes submit button, reset button, helper text behavior ([bc55e62](bc55e62)), closes [#59](#59) [#83](#83) [#47](#47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeanGroff SeanGroff

Labels
bug Something isn't working in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SeanGroff