fix: 🐛 SQFormDialogStepper validation works properly #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelbean
reviewed
Sep 1, 2022
laurelbean
reviewed
Sep 1, 2022
aharpt
approved these changes
Sep 2, 2022
20BBrown14
force-pushed
the
issue-790
branch
from
bf30fdb to
fd9af45
Compare
SQFormDialogStepper validation now respects validation schema properly. SQFormDialogStepper now validations on mount. BREAKING CHANGE: 🧨 SQFormDialogStepper respects validation schema ✅ Closes: #790
20BBrown14
force-pushed
the
issue-790
branch
from
fd9af45 to
565ebb3
Compare
laurelbean
approved these changes
Sep 9, 2022
lucas-homer
approved these changes
Sep 9, 2022
kaylamc2
pushed a commit
that referenced
this pull request
Dec 2, 2022
## [10.0.0](v9.7.0...v10.0.0) (2022-12-02) ### ⚠ BREAKING CHANGES * 🧨 SQFormDialogStepper respects validation schema * 🧨 Renamed rows and maxRows props on SQFormTextarea ### Features * 🎸 Migrate InclusionList to MUI5 ([7c8b982](7c8b982)), closes [#729](#729) * 🎸 Migrate SQFormAutoComplete to MUI5 ([0657e4b](0657e4b)), closes [#723](#723) ### Bug Fixes * 🐛 SQFormDialogStepper validation works properly ([#791](#791)) ([bf6b18e](bf6b18e)), closes [#790](#790) * 🐛 SQFormScrollable cards accepts value and label props ([#793](#793)) ([1a669b3](1a669b3)), closes [#792](#792) ### Code Refactoring * 💡 SQFormTextarea to MUIv5 ([30d2301](30d2301)), closes [#710](#710)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQFormDialogStepper validation now respects validation schema properly.
SQFormDialogStepper now validations on mount.
BREAKING CHANGE: 🧨 SQFormDialogStepper respects validation schema
✅ Closes: #790
Loom: https://www.loom.com/share/6cd90ed9ec124121b0a72a187fbe0dc8
DO NOT MERGE UNTIL #793 is merged