Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQFormScrollableCard should accept value and label props for use with SQFormScrollableCardMenuWrapper #792

Closed
Tracked by #447
20BBrown14 opened this issue Aug 31, 2022 · 0 comments
Closed
Tracked by #447

SQFormScrollableCard should accept value and label props for use with SQFormScrollableCardMenuWrapper #792

20BBrown14 opened this issue Aug 31, 2022 · 0 comments
Assignees
@20BBrown14

Comments

@20BBrown14
Copy link
Contributor

20BBrown14 commented Aug 31, 2022 •
edited
Loading

SQFormScrollableCardMenuWrapper was designed to be used to select from an array of SQFormScrollableCards. To allow that SQFormScrollableCard should accept value and label on the props so that the MenuWrapper can use it properly
@20BBrown14 20BBrown14 mentioned this issue Aug 31, 2022
Closed
50 tasks
@20BBrown14 20BBrown14 self-assigned this Aug 31, 2022
20BBrown14 added a commit that referenced this issue Aug 31, 2022
@20BBrown14
fix: 🐛 SQFormScrollable cards accepts value and label props
b62d1e8 
SQFormScrollableCard now accepts value and label as props to accomodate
SQFormScrollableCardsMenuWrapper

✅ Closes: #792
@20BBrown14 20BBrown14 mentioned this issue Aug 31, 2022
Merged
20BBrown14 added a commit that referenced this issue Sep 1, 2022
@20BBrown14
fix: 🐛 SQFormScrollable cards accepts value and label props
b0cbe60 
SQFormScrollableCard now accepts value and label as props to accomodate
SQFormScrollableCardsMenuWrapper

✅ Closes: #792
20BBrown14 added a commit that referenced this issue Sep 2, 2022
@20BBrown14
fix: 🐛 SQFormScrollable cards accepts value and label props
a0e8006 
SQFormScrollableCard now accepts value and label as props to accomodate
SQFormScrollableCardsMenuWrapper

✅ Closes: #792
20BBrown14 added a commit that referenced this issue Sep 6, 2022
@20BBrown14
fix: 🐛 SQFormScrollable cards accepts value and label props (#793)
1a669b3 
SQFormScrollableCard now accepts value and label as props to accomodate
SQFormScrollableCardsMenuWrapper

✅ Closes: #792
kaylamc2 pushed a commit that referenced this issue Dec 2, 2022
@semantic-release-bot
chore(release): 10.0.0 [skip ci]
e1671a0 
## [10.0.0](v9.7.0...v10.0.0) (2022-12-02)

### ⚠ BREAKING CHANGES

* 🧨 SQFormDialogStepper respects validation schema
* 🧨 Renamed rows and maxRows props on SQFormTextarea

### Features

* 🎸 Migrate InclusionList to MUI5 ([7c8b982](7c8b982)), closes [#729](#729)
* 🎸 Migrate SQFormAutoComplete to MUI5 ([0657e4b](0657e4b)), closes [#723](#723)

### Bug Fixes

* 🐛 SQFormDialogStepper validation works properly ([#791](#791)) ([bf6b18e](bf6b18e)), closes [#790](#790)
* 🐛 SQFormScrollable cards accepts value and label props ([#793](#793)) ([1a669b3](1a669b3)), closes [#792](#792)

### Code Refactoring

* 💡 SQFormTextarea to MUIv5 ([30d2301](30d2301)), closes [#710](#710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@20BBrown14 20BBrown14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@20BBrown14