Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

belindas-closet-nextjs_10_513_edit-user-role-page-responsive-ui #514

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

intisarosman1
Copy link
Contributor

@intisarosman1 intisarosman1 commented Jul 25, 2024

Resolves #513

This PR improves the UI appearance of the Edit User Role page, implements responsive UI for mobile screens, centers the Snackbar messages, and disables the "Ok" dialog button until changes are made to the user's role.

Screenshot 2024-07-25 001628
Screenshot 2024-07-25 001641
Screenshot 2024-07-25 011622
Screenshot 2024-07-25 001700
Screenshot 2024-07-25 001712

Resolves #513

This PR improves the UI appearance of the Edit User Role page, implements responsive UI for mobile screens and disables the "Ok" dialog button until changes are made to the user's role.
Copy link
Contributor

@heosman heosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

image

@heosman heosman changed the title bleindas-closet-nextjs_10_513_edit-user-role-page-responsive-ui belindas-closet-nextjs_10_513_edit-user-role-page-responsive-ui Jul 28, 2024
Copy link
Contributor

@Asfand00 Asfand00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice work @intisarosman1.
edit-user-role-page-dark
edit-user-role-page-light
edit-user-role-page-dialogue

I also saw that you centered the snack bar message as well.

@intisarosman1 intisarosman1 merged commit dad8263 into main Jul 28, 2024
6 checks passed
@keiffer213 keiffer213 deleted the refactor-513-edit-user-role-page-responsive-ui-01 branch October 13, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Sprint 10
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Refactor: Edit User Role Page Responsive UI
3 participants