belindas-closet-nextjs_6_351_update-product-sizing #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 7, 2024 19:13
Added sizes 4 and 13, and half-sizes.
heosman
requested review from
tinpham5614,
taylorpapke,
a team,
bcko,
Exochos,
Seiyaroo,
brinkbrink and
Robel-003
and removed request for
a team
taylorpapke
requested review from
Alzavio,
jonathonkindle,
LilithLucifer3x6,
ogarmela,
Diego-Cano,
alasali1,
nhapham03 and
MiguelQuintana1
taylorpapke
approved these changes
May 8, 2024
intisarosman1
approved these changes
May 8, 2024
|
This commit works as explained in the issue. All looks good to me |
nickolasram
approved these changes
May 9, 2024
Asfand00
added a commit
that referenced
this pull request
May 10, 2024
* Belindas closet nextjs 5 300 qa testing 3 (#330) * add testing configurations * add tests to product and auth pages * belindas-closet-nextjs_5_288-327_EditUserRoleDialog-Component-Alert (#316) * belindas-closet-nextjs_5_334_add-a-link-button-to-visualization-dashboard (#335) * the dashboard link has been added * UI styling has been added * Belinda_NextJS_Sprint_6_332_Dashboard_Creator_Link (#337) * Added Dashboard Link to the Creator Page * I added material UI to the dashboard button and also the other button * belindas-closet-nextjs_6_351_update-product-sizing (#355) * Update shoe sizing Added sizes 4 and 13, and half-sizes. * Add odd numbers for waist lengths of pants * Added odd numbers for inseam lengths for pants * replaced API URL as URL variables (#358) Co-authored-by: Tuong Pham Minh <[email protected]> --------- Co-authored-by: Isaac J <[email protected]> Co-authored-by: kaimanasse15 <[email protected]> Co-authored-by: MuhammadouDrammeh <[email protected]> Co-authored-by: hanan o <[email protected]> Co-authored-by: Tuong Pham Minh <[email protected]> Co-authored-by: Tuong Pham Minh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #351
This PR adds sizes 4, 13, and half-sizes to the shoe sizes dropdown on the Add Product page. It also adds odd numbers for waist and inseam lengths between 28 and 42 for pants.
Shoe sizes:
Waist and inseam sizes:
Related to #350