Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Belindas closet nextjs 5 300 qa testing 3 #330

Merged
merged 2 commits into from
May 1, 2024

Conversation

IsaacJrTypes
Copy link
Contributor

Fixes commit signature issues. Contains config files and tests on pages

Refer to old pull request for more details: #306

CleanShot 2024-04-29 at 20 09 01@2x

@IsaacJrTypes IsaacJrTypes self-assigned this Apr 30, 2024
@IsaacJrTypes IsaacJrTypes marked this pull request as ready for review April 30, 2024 03:54
@taylorpapke taylorpapke requested review from a team, bcko, Exochos, Seiyaroo, tinpham5614, heosman, brinkbrink, Robel-003 and taylorpapke and removed request for a team April 30, 2024 09:47
Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end:
Screenshot 2024-04-30 at 2 47 07 AM

Copy link
Contributor

@tinpham5614 tinpham5614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

For those who want to test this PR

  1. Pull this PR
  2. Install missing packages:
    npm install
  3. Run test
    npm run test
  4. Run test with coverage (optional)
    npm run test:coverage

Copy link
Contributor

@nickolasram nickolasram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me 👌 I think I should be the last approval you need to merge it this into main!

@IsaacJrTypes IsaacJrTypes merged commit e27906a into main May 1, 2024
6 checks passed
@IsaacJrTypes IsaacJrTypes deleted the Belindas-closet-nextjs-5-300-QA-Testing-3 branch May 1, 2024 23:35
Asfand00 added a commit that referenced this pull request May 10, 2024
* Belindas closet nextjs 5 300 qa testing 3 (#330)

* add testing configurations

* add tests to product and auth pages

* belindas-closet-nextjs_5_288-327_EditUserRoleDialog-Component-Alert (#316)

* belindas-closet-nextjs_5_334_add-a-link-button-to-visualization-dashboard (#335)

* the dashboard link has been added

* UI styling has been added

* Belinda_NextJS_Sprint_6_332_Dashboard_Creator_Link (#337)

* Added Dashboard Link to the Creator Page

* I added material UI to the dashboard button and also the other button

* belindas-closet-nextjs_6_351_update-product-sizing (#355)

* Update shoe sizing

Added sizes 4 and 13, and half-sizes.

* Add odd numbers for waist lengths of pants

* Added odd numbers for inseam lengths for pants

* replaced API URL as URL variables (#358)

Co-authored-by: Tuong Pham Minh <[email protected]>

---------

Co-authored-by: Isaac J <[email protected]>
Co-authored-by: kaimanasse15 <[email protected]>
Co-authored-by: MuhammadouDrammeh <[email protected]>
Co-authored-by: hanan o <[email protected]>
Co-authored-by: Tuong Pham Minh <[email protected]>
Co-authored-by: Tuong Pham Minh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants